[bug:ui] Notification toast disappears due to page reload

[Aryamanz29]

I encountered a bug while implementing background API tasks for the ZeroTier VPN backend in openwisp-controller.

When a background API task encounters an unrecoverable failure or recovers from any API failures, it generates an error or recovery type notification, respectively. However, if this notification is generated right after saving or updating the VPN object, the notification toast gets automatically dismissed due to the already-present Django model object's success message.

I tried to address this issue by adding some delay to the notification, but this solution may not be optimal. We need to find a better and more reliable solution to prevent the notification toast from disappearing prematurely.

[pandafy]

@Aryamanz29 you misinterpreted the bug here.

When the user clicks on the "Save and Continue" or "Save" button, the webpage reloads. This closes the websocket connection. The websocket connection is established again after the page loads.

The notification toast is only shown when a notification is received through the websocket connection.

[nemesifier]

@Aryamanz29 you misinterpreted the bug here.

When the user clicks on the "Save and Continue" or "Save" button, the webpage reloads. This closes the websocket connection. The websocket connection is established again after the page loads.

The notification toast is only shown when a notification is received through the websocket connection.

@pandafy do you think we could use javascript to intercept when the page is performing something like a save operation (eg: reloading, loading) and halt the consumption of websocket messages with the goal of letting the toast appear on the next reload? Or we could send back to the server a message communicating that the client is busy now but would like to receive the message again.

The goal would be to show the toast after the page has completed reloading.

[pandafy]

halt the consumption of websocket messages with the goal of letting the toast appear on the next reload?

We can add JS to disconnect the websocket connection on beforeunload. The channels wesocket consumer can only send notification to active connections.

[nemesifier]

halt the consumption of websocket messages with the goal of letting the toast appear on the next reload?

We can add JS to disconnect the websocket connection on beforeunload. The channels wesocket consumer can only send notification to active connections.

So in that case the notification toast would appear on the new page load, right?

[pandafy]

So in that case the notification toast would appear on the new page load, right?

I will have to double check with a PoC.