Add jersey server jakarta module#1458
Conversation
|
@codefromthecrypt - Would appreciate a review. Happy to accommodate any changes or alternative approaches too |
codefromthecrypt
left a comment
codefromthecrypt
left a comment
There was a problem hiding this comment.
The approach follows others like JMS. Basically @reta and/or I need to second eye review nothing was missed in the find/replace adjustment
| <parent> | ||
| <groupId>io.zipkin.brave</groupId> | ||
| <artifactId>brave-instrumentation-parent</artifactId> | ||
| <version>6.1.1-SNAPSHOT</version> |
There was a problem hiding this comment.
We need to bump all poms to 6.2.0-SNAPSHOT and verify the since javadoc on public types are since 6.2
Co-authored-by: Andriy Redko <[email protected]>
| ### Normal configuration (`TracingApplicationEventListener`) | ||
|
|
||
| The `TracingApplicationEventListener` requires an instance of | ||
| `HttpTracing` to operate. With that in mind, use [standard means](https://jersey.github.io/apidocs/2.26/jersey/org/glassfish/jersey/server/monitoring/ApplicationEventListener.html) |
There was a problem hiding this comment.
this link needs an update, too
reta
left a comment
reta
left a comment
There was a problem hiding this comment.
@dennyac could you please address a few comments from @codefromthecrypt , LGTM otherwise, thank you!
|
@reta - Addressed the comments. Updated the README and bumped all poms. Let me know if any other changes are needed. And thanks for your review |
|
@dennyac thank you! @codefromthecrypt LGTY? thanks! |
|
Thanks again |
3 participants
A copy of jersey-server module to work with jakarta namespace. There are references to javax classes like WebApplicationException in the jersey-server module