bug/74385: Inline work package chip has no visual highlight when selected#124
Open
ihordubas99 wants to merge 1 commit intodevfrom
Open
bug/74385: Inline work package chip has no visual highlight when selected#124ihordubas99 wants to merge 1 commit intodevfrom
ihordubas99 wants to merge 1 commit intodevfrom
Conversation
judithroth
requested changes
Apr 30, 2026
Contributor
judithroth
left a comment
There was a problem hiding this comment.
Funny again. This one works in the vite test project, but not in OpenProject. I'v rebuilt it several times to be sure. Can you reproduce this?
Collaborator
Author
|
@judithroth It's a bit strange that it doesn't work on your end - everything works fine for me. Here's how I do a full rebuild: op-blocknote-extension: After that, copy the generated openproject: Is this how you're doing it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/projects/communicator-stream/work_packages/74385
What are you trying to accomplish?
Add a visual selection highlight to inline work package chips when they are included in an editor text selection
Screenshots
What approach did you choose and why?
Subscribed to
editor.onSelectionChangeinside the chip component and usedrange.intersectsNodeto check whether the chip's DOM node falls within the current browser selection. When it does, the existingselectedstyled-component prop is activated, reusing the already-defined focus outline and shadow styles.Merge checklist