[#61546] Fix DangerDialog scroll behaviour w/form + system test#244
Draft
[#61546] Fix DangerDialog scroll behaviour w/form + system test#244
Conversation
|
myabc
changed the base branch from
main
to
fix/61546-danger-dialog-scroll-behaviour
myabc
changed the title
myabc
added
bug
10 tasks
myabc
force-pushed
the
fix/61546-danger-dialog-scroll-behaviour-test
branch
from
437dd0b to
182d9eb
Compare
myabc
force-pushed
the
fix/61546-danger-dialog-scroll-behaviour
branch
from
5c45a6f to
79986c4
Compare
Base automatically changed from
fix/61546-danger-dialog-scroll-behaviour
to
main
February 20, 2025 12:39
myabc
force-pushed
the
fix/61546-danger-dialog-scroll-behaviour-test
branch
from
182d9eb to
83fd601
Compare
Verifies confirm and cancel buttons are always visible.
myabc
force-pushed
the
fix/61546-danger-dialog-scroll-behaviour-test
branch
from
83fd601 to
96d8432
Compare
Default to current viewport width / height accordingly, allowing tests
to resize by only one dimension:
window.resize(height: 250)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is based on #243 - please review/merge that PR first.What are you trying to accomplish?
Fix Danger Dialog scroll behaviour when the dialog contains a form + verify behaviour is correct with system test.
Screenshots
See #243
Integration
N/A
List the issues that this change affects.
https://community.openproject.org/wp/61546
Risk Assessment
What approach did you choose and why?
Anything you want to highlight for special attention from reviewers?
Accessibility
Merge checklist