Update ruleset for shadowing builtins#645
Conversation
|
Warning Rate limit exceeded@ogenstad has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 3 minutes and 27 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (2)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## infrahub-develop #645 +/- ##
=================================================
Coverage 75.56% 75.56%
=================================================
Files 113 113
Lines 9514 9514
Branches 1448 1448
=================================================
Hits 7189 7189
Misses 1838 1838
Partials 487 487
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
a172c33 to
38ac489
Compare
Deploying infrahub-sdk-python with
|
| Latest commit: |
38ac489
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://283d5ef0.infrahub-sdk-python.pages.dev |
| Branch Preview URL: | https://pog-ruff-builtin-filter-infr.infrahub-sdk-python.pages.dev |
Disallow adding additional shadows for builtins, fix a case where we were shadowing
dir, added the other known ones to an ignore list for now.