merge develop to infrahub-develop#662
Conversation
WalkthroughThis pull request removes the Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying infrahub-sdk-python with
|
| Latest commit: |
e14e838
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8db74a83.infrahub-sdk-python.pages.dev |
| Branch Preview URL: | https://merge-develop.infrahub-sdk-python.pages.dev |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (7)
changelog/+08aa1a85.removed.md(1 hunks)infrahub_sdk/node/attribute.py(1 hunks)infrahub_sdk/node/constants.py(1 hunks)infrahub_sdk/protocols_base.py(0 hunks)infrahub_sdk/schema/__init__.py(0 hunks)tests/unit/sdk/conftest.py(5 hunks)tests/unit/sdk/test_node.py(3 hunks)
💤 Files with no reviewable changes (2)
- infrahub_sdk/schema/init.py
- infrahub_sdk/protocols_base.py
🧰 Additional context used
📓 Path-based instructions (4)
**/*.py
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.py: All async operations must have corresponding sync implementations following the dual implementation pattern
Use mypy with strict configuration for type checking in Python files
Files:
infrahub_sdk/node/constants.pytests/unit/sdk/conftest.pytests/unit/sdk/test_node.pyinfrahub_sdk/node/attribute.py
**/node/*.py
📄 CodeRabbit inference engine (CLAUDE.md)
**/node/*.py: Implement lazy loading for node attributes and relationships to load on demand
Support batch operations for bulk create/update/delete operations on nodes
Include built-in data validation with GraphQL query generation for nodes
Files:
infrahub_sdk/node/constants.pyinfrahub_sdk/node/attribute.py
tests/unit/**/*.py
📄 CodeRabbit inference engine (CLAUDE.md)
Place unit tests in
tests/unit/directory for testing individual components in isolation
Files:
tests/unit/sdk/conftest.pytests/unit/sdk/test_node.py
**/*.md
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.md: Use markdownlint for documentation consistency
Use Vale for documentation style checking
Follow markdown style as defined in.markdownlint.yamlconfiguration
Files:
changelog/+08aa1a85.removed.md
🪛 GitHub Actions: CI
infrahub_sdk/node/attribute.py
[error] 56-56: Ruff: 1 error found. Replace data.get("is_protected", None) with data.get("is_protected").
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Cloudflare Pages
🔇 Additional comments (4)
changelog/+08aa1a85.removed.md (1)
1-1: LGTM! Clear changelog entry.The changelog entry accurately documents the removal of the
is_visibleproperty from Infrahub.infrahub_sdk/node/constants.py (1)
4-4: LGTM! Property flag updated correctly.The removal of
is_visiblefromPROPERTIES_FLAGis consistent with the PR objective and properly updates the constant used throughout the codebase.tests/unit/sdk/conftest.py (1)
1238-1238: LGTM! Test fixtures updated consistently.All test fixtures have been properly updated to remove
is_visiblefrom the properties dictionaries, aligning with the removal of this property from the codebase.Also applies to: 1330-1330, 1338-1338, 1348-1348, 1910-1910, 1918-1918, 1997-1997, 2005-2005
tests/unit/sdk/test_node.py (1)
1673-1673: LGTM! Test expectations updated correctly.Test expectations have been properly updated to reflect the removal of
is_visiblefrom the data structures. The changes are consistent across multiple test scenarios.Also applies to: 1676-1676, 1827-1827, 1830-1830, 2053-2055
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## infrahub-develop #662 +/- ##
====================================================
+ Coverage 75.60% 75.61% +0.01%
====================================================
Files 113 113
Lines 9522 9518 -4
Branches 1452 1451 -1
====================================================
- Hits 7199 7197 -2
+ Misses 1832 1830 -2
Partials 491 491
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
1 participant
Summary by CodeRabbit
Breaking Changes
Schema Updates
Tests
✏️ Tip: You can customize this high-level summary in your review settings.