Skip to content

Add missing external identities protocol#972

Merged
solababs merged 1 commit intoinfrahub-developfrom
sb-27042026-add-missing-external-identities
Apr 27, 2026
Merged

Add missing external identities protocol#972
solababs merged 1 commit intoinfrahub-developfrom
sb-27042026-add-missing-external-identities

Conversation

@solababs
Copy link
Copy Markdown
Contributor

Add missing InternalExternalIdentity node to protocols

@solababs solababs requested a review from a team as a code owner April 27, 2026 08:42
@solababs solababs changed the title Add missing external identities Add missing external identities protocol Apr 27, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@                 Coverage Diff                  @@
##           infrahub-develop     #972      +/-   ##
====================================================
- Coverage             82.59%   81.43%   -1.16%     
====================================================
  Files                   134      134              
  Lines                 13320    11359    -1961     
  Branches               2307     1703     -604     
====================================================
- Hits                  11001     9250    -1751     
+ Misses                 1677     1566     -111     
+ Partials                642      543      -99     
Flag Coverage Δ
integration-tests 41.90% <100.00%> (-2.92%) ⬇️
python-3.10 54.41% <100.00%> (-2.52%) ⬇️
python-3.11 54.41% <100.00%> (-2.50%) ⬇️
python-3.12 54.41% <100.00%> (-2.52%) ⬇️
python-3.13 54.39% <100.00%> (-2.54%) ⬇️
python-3.14 54.39% <100.00%> (-2.54%) ⬇️
python-filler-3.12 22.72% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
infrahub_sdk/protocols.py 100.00% <100.00%> (ø)

... and 17 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ogenstad
Copy link
Copy Markdown
Contributor

Hm, actually there are for things for the Internal namespace, we might have another bug in the generation code for this since I see that we also have the tokens relationship on CoreAccount and tokens is also in the Internal namespace, so I think the correct thing here would actually be to ensure that we don't render anything related to the Internal repo in the SDK.. Could be that we should have another issue for that, it should be safe to merge this to avoid having the generation spit out things over and over if we don't add them, but at some point it would be better to remove those entries.

@solababs solababs merged commit 3805e4d into infrahub-develop Apr 27, 2026
20 checks passed
@solababs solababs deleted the sb-27042026-add-missing-external-identities branch April 27, 2026 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants