Skip to content

Fix type for items mapping#983

Merged
ogenstad merged 1 commit intostablefrom
pog-fix-items-mapping
Apr 30, 2026
Merged

Fix type for items mapping#983
ogenstad merged 1 commit intostablefrom
pog-fix-items-mapping

Conversation

@ogenstad
Copy link
Copy Markdown
Contributor

Why

Add typehints to dict to remove type ignore comment

What changed

Typehints on dictionary and removal of type ignore statement.

@cloudflare-workers-and-pages
Copy link
Copy Markdown

Deploying infrahub-sdk-python with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6cff19c
Status: ✅  Deploy successful!
Preview URL: https://45a86db6.infrahub-sdk-python.pages.dev
Branch Preview URL: https://pog-fix-items-mapping.infrahub-sdk-python.pages.dev

View logs

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@           Coverage Diff           @@
##           stable     #983   +/-   ##
=======================================
  Coverage   81.41%   81.41%           
=======================================
  Files         134      134           
  Lines       11347    11347           
  Branches     1703     1703           
=======================================
  Hits         9238     9238           
  Misses       1566     1566           
  Partials      543      543           
Flag Coverage Δ
integration-tests 41.84% <0.00%> (-0.01%) ⬇️
python-3.10 54.34% <50.00%> (-0.02%) ⬇️
python-3.11 54.36% <50.00%> (ø)
python-3.12 54.34% <50.00%> (-0.02%) ⬇️
python-3.13 54.36% <50.00%> (ø)
python-3.14 54.34% <50.00%> (-0.02%) ⬇️
python-filler-3.12 22.74% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
infrahub_sdk/pytest_plugin/loader.py 78.72% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ogenstad ogenstad marked this pull request as ready for review April 30, 2026 07:27
@ogenstad ogenstad requested a review from a team as a code owner April 30, 2026 07:27
@ogenstad ogenstad merged commit 013341c into stable Apr 30, 2026
20 checks passed
@ogenstad ogenstad deleted the pog-fix-items-mapping branch April 30, 2026 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants