Refactor(Hangul): Simplify LV/LVT classification and improve performance#34
Open
rmaksim wants to merge 1 commit into
Open
Refactor(Hangul): Simplify LV/LVT classification and improve performance#34rmaksim wants to merge 1 commit into
rmaksim wants to merge 1 commit into
Conversation
Replaced lengthy 'if' chains and explicit range checks for Hangul (Korean) syllables with a single mathematical check based on the Unicode standard. What was simplified: * Eliminated two large, complex conditional blocks (`if` statements) that manually enumerated dozens of code points and ranges for LV and LVT syllable types. * Improved code readability by replacing imperative, error-prone enumeration with a single, declarative formula: `(code - 0xAC00) % 28`. What was optimized: * **Performance (CPU):** Significantly reduced execution time by replacing numerous sequential OR (`||`) and range checks with a single range check and one modulo operation (`% 28`). This is faster for the JavaScript engine. * **Code Size:** Dramatically reduced the file size and complexity by removing the bulky code dedicated to manually implementing Unicode rules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced lengthy 'if' chains and explicit range checks for Hangul (Korean) syllables with a single mathematical check based on the Unicode standard.
What was simplified:
ifstatements) that manually enumerated dozens of code points and ranges for LV and LVT syllable types.(code - 0xAC00) % 28.What was optimized:
||) and range checks with a single range check and one modulo operation (% 28). This is faster for the JavaScript engine.