fix(button): solve focus variant color issues#165
Merged
mlmoravek merged 1 commit intooruga-ui:mainfrom May 7, 2025
Merged
Conversation
mlmoravek
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a few minor bugs with button focus states
Focus vs Focus-Visible
Bulma prior to 1.0 uses :focus to control the focus ring on buttons but 1.0 switches to using :focus-visible. Theme-bulma has long overridden this focus style, but we didn't switch the override to focus-visible when we added support for Bulma 1.0. The result is the focus ring is a different color depending on how it is focused.
Screen.Recording.2025-03-31.at.2.23.06.PM.mov
Blue border with keyboard focus
The other issue is that our override misses the blue border coming from Bulma.
Screen.Recording.2025-03-31.at.3.18.18.PM.mov
The fix
This PR removes the :focus override completely, along with related variables. Instead, it sets the focus-* css variables to button colors. The resulting focus ring is identical but now flows through Bulma's focus-visible code so there's no mis-match. This also sets the border color.