fix: solve $enable-hosts adds dark styles when dark mode is removed#168
Merged
mlmoravek merged 6 commits intooruga-ui:mainfrom May 7, 2025
Merged
fix: solve $enable-hosts adds dark styles when dark mode is removed#168mlmoravek merged 6 commits intooruga-ui:mainfrom
mlmoravek merged 6 commits intooruga-ui:mainfrom
Conversation
Member
|
@whiplashwebb By removing the Any idea how we can fix this? I think by the following code because of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


I needed to switch to the bulma version without dark mode using the separate method of theme config. I was able to use that style of config without issue and most of Bulma's dark mode disappeared, but some remained. It turned out that
utils/_root.scsscallsbulma/sassto support$enable-host, which is harmless when you use the combined method because you've already pulled in that code. However, when used in a separated build that file hasn't been pulled in as you're always doing something custom with Bulma (like removing dark mode), so the @use has the effect of pulling in Bulma code so :root can be extended. This brings in the version frombulma/sasswhich includes dark mode css variables.To solve the problem I removed the @use, making the relationship implicit. Sass will still extend :root, but it will extend whatever :root has already been imported, either
bulma/sassfor the combined build or from a custom bulma build in the separated method. If you don't include bulma for some weird reason it will fail gracefully and extend nothing.I also changed the separated example to make this easier to reproduce locally.