fix(input): solve Input icon no longer shows Bulma hover/focus styles on left icon#169
Merged
mlmoravek merged 2 commits intooruga-ui:mainfrom May 7, 2025
Merged
Conversation
mlmoravek
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bulma supports adding hover and focus colors to input icons. Oruga has long supported this, but in the recent rewrites this functionality regressed. This PR fixes the problem.
Example of correct behaviour from Bulma docs
Screen.Recording.2025-04-03.at.12.36.37.PM.mov
Example of incorrect behaviour from Oruga docs
Screen.Recording.2025-04-03.at.12.49.00.PM.mov
What broke?
Bulma targets this style with a subsequent sibling selector sort of like this
When the input component was re-written the order of the input dom elements changed, going from
input, left icon, right icontoleft icon, input, right icon. This is totally logical since DOM order reflects visual order, but it breaks the Bulma selector for the left icon since it now comes before the focused input.Related: oruga-ui/oruga#1271
Proposed Changes