Skip to content

Intersection theory: small edits to changes from #5899#5911

Merged
wdecker merged 7 commits intooscar-system:masterfrom
pbelmans:pb/intersectiontheory
Apr 8, 2026
Merged

Intersection theory: small edits to changes from #5899#5911
wdecker merged 7 commits intooscar-system:masterfrom
pbelmans:pb/intersectiontheory

Conversation

@pbelmans
Copy link
Copy Markdown
Contributor

@pbelmans pbelmans commented Apr 1, 2026

These are minor edits to documentation improvements from #5899.

@thofma thofma added the release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes label Apr 1, 2026
Comment on lines +4034 to +4036
comes equipped with a sequence of tautological subbundles $0 = \mathcal{S}_0, \mathcal{S}_1 \subset \dots \subset
\mathcal{S}_k\subset \mathcal{S}_{k+1} = \pi^\ast(E)$ of ranks $0 = d_0, d_1, \dots, d_k, d_{k+1} = n$ together with the
subquotient bundles $\mathcal{SQ}_j = \mathcal{S}_j/\mathcal{S}_{j-1}$. To present the Chow ring of $\mathrm{F}(d_1, \dots, d_{k}; E)$
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pbelmans What is our rule here: The vector bundles SQ_j are in \mathcal, whereas E and many other vector bundles in the docu are not. See, for example, the docstring of abstract_grassmannian.

$\mathrm{N}^\ast(\mathrm{F}(d_1, \dots, d_{k}; E))_{\mathbb Q}\cong \mathrm{N}^\ast(X)_{\mathbb Q}[c_{ij} \mid 1\leq j \leq k+1, 1 \leq i \leq d_j-d_{j-1}]/(\mathrm{relations}).$

Here, the $c_{ij}$ are in degree $j$, and we mod out the homogeneous relations arising from the relation
Here, the $c_{ij}$ are in degree $i$, and we mod out the homogeneous relations arising from the relation
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pbelmans Thx for catching this, but there is more to do! I apologize for being unconcentrated here and similarly in the docstring of abstract_flag_variety. We are quoting 3 papers: GSS22, HK-MW24, and Grothendiecks's original paper Gro58. in the docstrings, I followed Grothendieck's notation, whereas what is implemented follows the notation in the first two papers: the roles ofiand j are interchanged. I will double check and correct this as soon as the current PR is merged.

@wdecker wdecker closed this Apr 8, 2026
@wdecker wdecker reopened this Apr 8, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.00%. Comparing base (a4441ca) to head (351e276).
⚠️ Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5911      +/-   ##
==========================================
- Coverage   84.02%   84.00%   -0.03%     
==========================================
  Files         779      779              
  Lines      106389   106971     +582     
==========================================
+ Hits        89393    89858     +465     
- Misses      16996    17113     +117     
Files with missing lines Coverage Δ
experimental/IntersectionTheory/src/main.jl 96.46% <ø> (ø)

... and 10 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wdecker wdecker merged commit fe03c35 into oscar-system:master Apr 8, 2026
98 of 101 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants