Skip to content

Delete examples/GSets_timing.jl#5928

Open
lgoettgens wants to merge 1 commit intomasterfrom
lg/examples_GSets_timing
Open

Delete examples/GSets_timing.jl#5928
lgoettgens wants to merge 1 commit intomasterfrom
lg/examples_GSets_timing

Conversation

@lgoettgens
Copy link
Copy Markdown
Member

this contains some benchmarks from two years ago, that have not been used since then (at least I think so).

Towards #280.

@lgoettgens lgoettgens requested a review from mjrodgers April 9, 2026 13:17
@lgoettgens lgoettgens added the release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes label Apr 9, 2026
@HereAround HereAround requested a review from fingolfin April 9, 2026 13:40
@HereAround
Copy link
Copy Markdown
Member

I actually touched on this with @mjrodgers a while ago; no strong opinion if I recall correctly, but rather for @fingolfin to decide.

@mjrodgers
Copy link
Copy Markdown
Collaborator

I created them at the request of @fingolfin so that we could compare timings of the GSet methods among different versions and check for regressions. At the moment we don't have any automated timing tests, but if a user is modifying GSet code they can run these benchmarks against their commit to see if the timings are affected.

Is the point that the examples folder needs to go away? If so, maybe there is another place for these to be moved to. As is, they don't add anything to CI or take up much memory, so I don't know the motivation to delete them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants