Open
Conversation
Member
|
I actually touched on this with @mjrodgers a while ago; no strong opinion if I recall correctly, but rather for @fingolfin to decide. |
Collaborator
|
I created them at the request of @fingolfin so that we could compare timings of the GSet methods among different versions and check for regressions. At the moment we don't have any automated timing tests, but if a user is modifying GSet code they can run these benchmarks against their commit to see if the timings are affected. Is the point that the examples folder needs to go away? If so, maybe there is another place for these to be moved to. As is, they don't add anything to CI or take up much memory, so I don't know the motivation to delete them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this contains some benchmarks from two years ago, that have not been used since then (at least I think so).
Towards #280.