trigger error if popup is closed prematurely#135
Merged
bhousel merged 1 commit intoosmlab:mainfrom Jan 17, 2025
Merged
Conversation
as the popup is typically operating on a cross origin domain, the only reliable way to check the status of the popup is to regularly poll its `closed` status. see https://stackoverflow.com/a/78372804/1627467
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, consumer applications don't get notified when the login process is aborted by closing the login popup window, causing these applications being stuck in a waiting for login to complete state. As the login popup is often on a different domain than the application, there only way to find out that the popup was closed prematurely is by adding a watchdog loop which periodically checks if window is still open.
Fixes openstreetmap/iD#10651