Conversation
| if(trace) { | ||
| #ifdef _WIN32 | ||
| // On Windows, mkdir takes only one argument | ||
| int status = mkdir(trace_directory.c_str()); |
There was a problem hiding this comment.
On Windows, consider using _mkdir from <direct.h> instead of mkdir; this will ensure compatibility with MSVC.
Suggested change
| int status = mkdir(trace_directory.c_str()); | |
| int status = _mkdir(trace_directory.c_str()); |
| ParameterTracer::ParameterTracer(bool trace, bool trace_latent, const std::string& trace_directory) | ||
| : trace { trace }, trace_latent { trace_latent }, trace_directory { trace_directory } { | ||
| if(trace) { | ||
| #ifdef _WIN32 |
There was a problem hiding this comment.
When using _mkdir, include the header <direct.h> in the Windows-specific branch to ensure the function is declared.
Suggested change
| #ifdef _WIN32 | |
| #ifdef _WIN32 | |
| #include <direct.h> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.