Skip to content

Topological sorts in memory rather than in files#27

Merged
osorensen merged 3 commits intomainfrom
sorts-issue-26
Apr 11, 2025
Merged

Topological sorts in memory rather than in files#27
osorensen merged 3 commits intomainfrom
sorts-issue-26

Conversation

@osorensen
Copy link
Copy Markdown
Owner

No description provided.

@osorensen osorensen requested a review from Copilot April 11, 2025 08:30
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 8 out of 15 changed files in this pull request and generated no comments.

Files not reviewed (7)
  • R/RcppExports.R: Language not supported
  • R/compute_sequentially.R: Language not supported
  • man/compute_sequentially.Rd: Language not supported
  • man/precompute_topological_sorts.Rd: Language not supported
  • tests/testthat/test-all_topological_sorts.R: Language not supported
  • tests/testthat/test-compute_sequentially_partial.R: Language not supported
  • tests/testthat/test-compute_sequentially_preferences.R: Language not supported
Comments suppressed due to low confidence (2)

src/typedefs.h:19

  • [nitpick] Consider adding a brief comment clarifying that 'sort_matrices_tp' represents in-memory topological sort matrices to distinguish it from the previous file-based implementation.
using sort_matrices_tp = std::map<std::string, arma::umat>;

src/data.cpp:71

  • Ensure that the value from 'a[i]' is appropriately cast to a long long int (or the desired numeric type) to prevent potential data type mismatches or loss.
new_data[std::string(nm[i])] = a[i];

@osorensen osorensen merged commit 04e1022 into main Apr 11, 2025
5 checks passed
@osorensen osorensen deleted the sorts-issue-26 branch April 11, 2025 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants