Store captured samples in a hashmap during session#85
Merged
Conversation
'session->samples' is no longer used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch lets Pf2 store collected samples in a hashmap backed by khashl instead of a array. This allows far lower memory consumption - the original
session->samplesstored every single sample collected, making the profiler's memory footprint proportional to the target program's running time, but this new implementation only records counts of distinct stacks.Not done here:
(ruby_stack, pc)for dedup, but those could be managed separately. However that change would probably require changes in the serialization format.Benchmark
Max RSS of the following script:
(script written by Codex)