Skip to content

fix: Fix bytes being converted incorrectly in declare_program! #2966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
acheroncrypto merged 9 commits into from
May 15, 2024
Merged

fix: Fix bytes being converted incorrectly in declare_program! #2966

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
03544bd
add support for const generics in types inside of accounts
cryptopapi997 May 13, 2024
ef4d5fb
fix bytes being converted incorrectly
cryptopapi997 May 13, 2024
5fcb487
Update CHANGELOG.md
cryptopapi997 May 13, 2024
a8adf4b
Update CHANGELOG.md
cryptopapi997 May 13, 2024
a631cad
Merge pull request #1 from cryptopapi997/master
cryptopapi997 May 13, 2024
da4f8bb
Merge branch 'patched' into fix-bytes-conversion
cryptopapi997 May 13, 2024
89524b5
Merge branch 'master' into fix-bytes-conversion
cryptopapi997 May 14, 2024
ce4b351
Update common.rs
cryptopapi997 May 14, 2024
69bd596
Mention being unable to use `Vec<u8>` rather than `bytes` in CHANGELOG
acheroncrypto May 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ The minor version will be incremented upon a breaking change and the patch versi
- idl: Fix potential panic on external type resolution ([#2954](https://github.com/coral-xyz/anchor/pull/2954)).
- lang: Fix using defined types in instruction parameters with `declare_program!` ([#2959](https://github.com/coral-xyz/anchor/pull/2959)).
- lang: Fix using const generics with `declare_program!` ([#2965](https://github.com/coral-xyz/anchor/pull/2965)).
- lang: Fix bytes being incorrectly converted from IDL to Rust with `declare_program!` ([#2966](https://github.com/coral-xyz/anchor/pull/2966)).

### Breaking

Expand Down
5 changes: 4 additions & 1 deletion lang/attribute/program/src/declare_program/common.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,10 @@ pub fn gen_accounts_common(idl: &Idl, prefix: &str) -> proc_macro2::TokenStream
}

pub fn convert_idl_type_to_syn_type(ty: &IdlType) -> syn::Type {
syn::parse_str(&convert_idl_type_to_str(ty)).unwrap()
match ty {
IdlType::Bytes => syn::parse_str("Vec<u8>").unwrap(),
_ => syn::parse_str(&convert_idl_type_to_str(ty)).unwrap(),
}
Comment thread
cryptopapi997 marked this conversation as resolved.
Outdated
}

// TODO: Impl `ToString` for `IdlType`
Expand Down
⚡