lang: Fix instructions with no accounts causing compilation errors when using declare_program!#3567
Merged
Conversation
…en using `declare_program!`
|
@acheroncrypto is attempting to deploy a commit to the coral-xyz Team on Vercel. A member of the Team first needs to authorize it. |
Otter-0x4ka5h
pushed a commit
to Otter-0x4ka5h/anchor
that referenced
this pull request
Mar 25, 2026
…en using `declare_program!` (otter-sec#3567)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Instructions with no accounts result in compilation errors when they're used with
declare_program!.For example, using an IDL that has an instruction like the one mentioned in #3514 (comment)
{ "name": "refresh_reserves_batch", "discriminator": [144, 110, 26, 103, 162, 204, 252, 147], "accounts": [], "args": [ { "name": "skip_price_updates", "type": "bool" } ] }results in:
A similar issue (#1628) with the
cpifeature has existed roughly since the creation of Anchor, but this one is specifically for thecpimodule generated usingdeclare_program!. The benefit of using the IDL + macro approach here is that we have access to all instruction information (unlike with thecpifeature, where we only have access to the token stream), which we can then use to decide whether to add the generic lifetime or not.Summary of changes
Fix instructions with no accounts causing compilation errors when using
declare_program!by conditionally adding the lifetime parameter only when the instruction accounts are not empty.Fixes #3514