-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Add errors to declare program macro
#3757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jacobcreech
merged 3 commits into
otter-sec:master
from
cryptopapi997:feat/add-errors-to-decl-program
Jul 8, 2025
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| use anchor_lang_idl::types::Idl; | ||
| use quote::{format_ident, quote}; | ||
|
|
||
| pub fn gen_errors_mod(idl: &Idl) -> proc_macro2::TokenStream { | ||
| let errors = idl.errors.iter().map(|e| { | ||
| let name = format_ident!("{}", e.name); | ||
| quote! { | ||
| #name, | ||
| } | ||
| }); | ||
|
|
||
| if errors.len() == 0 { | ||
| return quote! { | ||
| /// Program error type definitions. | ||
| pub mod errors { | ||
| } | ||
| }; | ||
| } | ||
|
|
||
| quote! { | ||
| /// Program error type definitions. | ||
| pub mod errors { | ||
|
|
||
| #[anchor_lang::error_code] | ||
| pub enum ProgramError { | ||
| #(#errors)* | ||
| } | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might make the
errorsfield of the IDL inconsistent during generation i.e. programs that usedeclare_program!might get external program errors in their own IDL. This is because theerrorsfield of the IDL is populated via the same#[error_code]macro, meaning these declarations might conflict when there are multiple declarations in the same crate.This is also why we manually declare the program ID in our
declare_program!impl instead of just usingdeclare_id!(#3555 (comment)).Similar issue: #3438