use the correct version of the encrypted file#22259
Closed
Conversation
|
By analyzing the blame information on this pull request, we identified @LukasReschke, @DeepDiver1975 and @MorrisJobke to be potential reviewers |
Contributor
|
Let me smash this just in case |
Contributor
|
All smashbox tests failed. However @LukasReschke pointed out on IRC that there is another bug that the version doesn't get increased on master. It also doesn't get increased in this PR on webdav PUT. |
Contributor
|
raised here #22260 |
Contributor
|
@schiesbn is this still valid or obsolete by the other fixes ? |
Contributor
Author
|
If the other fix goes through, then this one is obsolete. |
Contributor
|
Obsoleted by #22267 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have no concrete bug for this. All tests I did work before and after this change, still I think that this is the right behavior.
see this PR/discussion for more details and how the bug was introduced: #21557 (comment)
cc @PVince81 @LukasReschke