Chunk the cleanup queries to make sure they don't time out#22269
Merged
DeepDiver1975 merged 1 commit intomasterfrom Feb 10, 2016
Merged
Conversation
|
By analyzing the blame information on this pull request, we identified @PVince81, @MorrisJobke and @blizzz to be potential reviewers |
nickvergessen
force-pushed
the
issue-22243-avoid-deadlock-with-lots-of-entries-to-cleanup
branch
from
bedecf8 to
51e6a92
Compare
Contributor
There was a problem hiding this comment.
CHUNK which means a piece, not JUNK which means garbage 😉
Contributor
There was a problem hiding this comment.
Also see number 3 in http://www.urbandictionary.com/define.php?term=junk
You might want to refrain using that word here
Contributor
Author
There was a problem hiding this comment.
Woops, the commit message was right
nickvergessen
force-pushed
the
issue-22243-avoid-deadlock-with-lots-of-entries-to-cleanup
branch
from
51e6a92 to
0ebb205
Compare
Contributor
|
Tested and works 👍 |
Contributor
|
👍 |
DeepDiver1975
added a commit
that referenced
this pull request
Feb 10, 2016
…th-lots-of-entries-to-cleanup Chunk the cleanup queries to make sure they don't time out
DeepDiver1975
deleted the
issue-22243-avoid-deadlock-with-lots-of-entries-to-cleanup
branch
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lib/private/repair/repairinvalidshares.phpFix #22243
@PVince81 @MorrisJobke