Possibly fix Gallery & files_mediaviewer compatibility issue.#310
Merged
mmattel merged 1 commit intoowncloud:masterfrom Nov 15, 2020
Merged
Possibly fix Gallery & files_mediaviewer compatibility issue.#310mmattel merged 1 commit intoowncloud:masterfrom
mmattel merged 1 commit intoowncloud:masterfrom
Conversation
This simple, no-harm change checks that `OCA.Files.fileActions` exists before using it. This seems to fix owncloud#102, the compatibility issue between the files_mediaviewer app and the old Gallery app. The edit allows javascript to continue without throwing an exception if `OCA.Files.fileActions` does not exist. For some reason this happens when both Gallery and files_mediaviewer are enabled in my installation of OwnCloud.
mmattel
approved these changes
Nov 15, 2020
This was referenced Jan 10, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simple, no-harm change checks that
OCA.Files.fileActionsexistsbefore using it. This seems to fix #102, the compatibility issue between the
files_mediaviewer app and the old Gallery app. The edit allows
javascript to continue without throwing an exception if
OCA.Files.fileActionsdoes not exist. For some reason this happenswhen both Gallery and files_mediaviewer are enabled in my installation
of OwnCloud.