fix(sse): use spaceid instead of itemid when refreshing drive on space membership SSE events#13761
Closed
dj4oC wants to merge 1 commit intoowncloud:masterfrom
Closed
fix(sse): use spaceid instead of itemid when refreshing drive on space membership SSE events#13761dj4oC wants to merge 1 commit intoowncloud:masterfrom
dj4oC wants to merge 1 commit intoowncloud:masterfrom
Conversation
…pace membership change For entitlement-managed spaces with a gp- prefix (OCIS_CLAIM_MANAGED_SPACES_REGEXP), the SSE itemid has the form storageId$spaceId!nodeId. Because nodeId equals spaceId for these spaces, the suffix is visible and causes getDriveBeta to return 404. The three space-membership SSE handlers (space-member-added, space-member-removed, space-share-updated) were passing sseData.itemid as the drive ID, but getDriveBeta expects only storageId$spaceId. Switch to sseData.spaceid, which carries the correct drive-ID format for all space types. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
space-member-added,space-member-removed,space-share-updated),getDrivewas called withsseData.itemidinstead ofsseData.spaceiditemidcarries the item-ID format (storageId$spaceId!nodeId), butgetDriveBetaexpects the drive-ID format (storageId$spaceId)OCIS_CLAIM_MANAGED_SPACES_REGEXPwith agp-prefix,nodeId === spaceId, making the malformed suffix visible and causing an immediate 404Root cause
packages/web-runtime/src/container/sse/shares.tslines 24, 54, 101:Call stack (de-minified)
Test plan
OCIS_CLAIM_MANAGED_SPACES_REGEXPconfigured, open a project space with agp-prefix as one browser tab/graph/v1beta1/drives/…in the first tab🤖 Generated with Claude Code