You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The symlinkJoin builder might be lighter on dependencies, but it actually creates a very inefficient directory structure, symlinking literally every file in the toolchain. This results in ~47k symlinks created with the default toolchain and takes a while on slower file systems.
The buildEnv builder depends on perl and is a bit awkward to use with propagated inputs, but it creates a much more efficient directory structure.
The symlinkJoin builder might be lighter on dependencies, but it actually creates a very inefficient directory structure, symlinking literally every file in the toolchain. This results in ~47k symlinks created with the default toolchain and takes a while on slower file systems.
That's definitely a problem I want to fix for a long time. But I don't know the "proper" method to produce the minimal symlink tree. It's good to know that buildEnv does a better job here.
The buildEnv builder depends on perl and is a bit awkward to use with propagated inputs
I agree. Since the aggregated drv is almost always built on users' machine, this change will force all users to download perl to build any toolchain, which is less ideal. But I think build-only dependency to perl is probably still better than persistent thousands of symlinks after-build.
Ideally, we would like to optimize upstream implementation of symlinkJoin.
The approach in this PR has an additional benefit of fixing #221 (just tested).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
symlinkJoinbuilder might be lighter on dependencies, but it actually creates a very inefficient directory structure, symlinking literally every file in the toolchain. This results in ~47k symlinks created with the default toolchain and takes a while on slower file systems.The
buildEnvbuilder depends onperland is a bit awkward to use with propagated inputs, but it creates a much more efficient directory structure.With
symlinkJoin:With
buildEnv: