Cucumber kafka tests refactored#7
Merged
ozgliderpilot merged 5 commits intoozgliderpilot:mainfrom Jun 16, 2025
Merged
Conversation
added 2 commits
June 16, 2025 16:45
…croserviceExamples into cucumber_kafka_tests_refactored
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the Kafka inspection tests by updating the Cucumber feature steps and refactoring the Java test step implementation to use a REST API for verification rather than a direct MongoDB query.
- Updated feature file step text to improve clarity
- Replaced direct MongoDB querying with a REST client call in the test step
- Introduced a new helper method for getting vehicle inspections by ID in the test class
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| memex/src/test/resources/features/inspections.kafka.feature | Updated step text to better describe the test behavior |
| memex/src/test/java/com/johnlpage/memex/cucumber/steps/KafkaConsumerSteps.java | Refactored the verification of vehicle inspections to use a REST API and added a new helper method for GET requests |
Comments suppressed due to low confidence (2)
memex/src/test/java/com/johnlpage/memex/cucumber/steps/KafkaConsumerSteps.java:81
- Since the RestClient is built using the apiBaseUrl, consider using a relative path (e.g. "/api/inspections/query") instead of concatenating the base URL. This can help ensure consistency and ease future changes to the base URL.
.uri(apiBaseUrl + "/api/inspections/query")
memex/src/test/java/com/johnlpage/memex/cucumber/steps/KafkaConsumerSteps.java:39
- The field 'restClientBuilder' is declared without any injection annotation or initialization. If this field is intended to be provided by dependency injection, add the appropriate annotation (e.g., @Autowired) to avoid potential null pointer issues at runtime.
private RestClient.Builder restClientBuilder;
| @@ -1,39 +1,56 @@ | |||
|
|
|||
added 2 commits
June 16, 2025 17:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cucumber kafka tests refactored