Skip to content

Cucumber kafka tests refactored#7

Merged
ozgliderpilot merged 5 commits intoozgliderpilot:mainfrom
rajatsharma2393:cucumber_kafka_tests_refactored
Jun 16, 2025
Merged

Cucumber kafka tests refactored#7
ozgliderpilot merged 5 commits intoozgliderpilot:mainfrom
rajatsharma2393:cucumber_kafka_tests_refactored

Conversation

@rajatsharma2393
Copy link
Copy Markdown
Collaborator

Cucumber kafka tests refactored

This comment was marked as outdated.

@ozgliderpilot ozgliderpilot requested a review from Copilot June 16, 2025 06:59
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the Kafka inspection tests by updating the Cucumber feature steps and refactoring the Java test step implementation to use a REST API for verification rather than a direct MongoDB query.

  • Updated feature file step text to improve clarity
  • Replaced direct MongoDB querying with a REST client call in the test step
  • Introduced a new helper method for getting vehicle inspections by ID in the test class

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
memex/src/test/resources/features/inspections.kafka.feature Updated step text to better describe the test behavior
memex/src/test/java/com/johnlpage/memex/cucumber/steps/KafkaConsumerSteps.java Refactored the verification of vehicle inspections to use a REST API and added a new helper method for GET requests
Comments suppressed due to low confidence (2)

memex/src/test/java/com/johnlpage/memex/cucumber/steps/KafkaConsumerSteps.java:81

  • Since the RestClient is built using the apiBaseUrl, consider using a relative path (e.g. "/api/inspections/query") instead of concatenating the base URL. This can help ensure consistency and ease future changes to the base URL.
.uri(apiBaseUrl + "/api/inspections/query")

memex/src/test/java/com/johnlpage/memex/cucumber/steps/KafkaConsumerSteps.java:39

  • The field 'restClientBuilder' is declared without any injection annotation or initialization. If this field is intended to be provided by dependency injection, add the appropriate annotation (e.g., @Autowired) to avoid potential null pointer issues at runtime.
private RestClient.Builder restClientBuilder;

@@ -1,39 +1,56 @@

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty lines?

Rajat Sharma added 2 commits June 16, 2025 17:14
@ozgliderpilot ozgliderpilot merged commit 85af1b6 into ozgliderpilot:main Jun 16, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants