token: sort paths for reproducible extract#656
Merged
ZoltanFridrich merged 1 commit intop11-glue:masterfrom Aug 30, 2024
Merged
token: sort paths for reproducible extract#656ZoltanFridrich merged 1 commit intop11-glue:masterfrom
ZoltanFridrich merged 1 commit intop11-glue:masterfrom
Conversation
ZoltanFridrich
requested changes
Aug 28, 2024
Contributor
ZoltanFridrich
left a comment
ZoltanFridrich
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
The change looks good overall, but I would like to see some things fixed before I can merge it.
Contributor
Author
Thanks for your feedback, I tried to incorporate the requested changes. Let me know if I overlooked something. :) |
Contributor
|
@katexochen please rebase it to master so I can merge. |
There is no defined order in which readdir will return the entries of a directory. In practice, order can depend on inode number or similar. If we run p11-kit on different files systems with similar directory structure but different inode order the output of extract can change. To get a stable and reproducible output, sort the paths returned by readdir before extracting. Co-authored-by: Tom Dohrmann <erbse.13@gmx.de> Signed-off-by: Paul Meyer <49727155+katexochen@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no defined order in which readdir will return the entries of a directory. In practice, order can depend on inode number or similar. If we run p11-kit on different files systems with similar directory structure but different inode order the output of extract can change.
To get a stable and reproducible output, sort the paths returned by readdir before extracting.