Update project to require C++17#1266
Update project to require C++17#1266antoninbas merged 5 commits intop4lang:mainfrom OsamaRab3:update
Conversation
|
@antoninbas please review my PR |
antoninbas
left a comment
antoninbas
left a comment
There was a problem hiding this comment.
I wonder if the reference to C++11 in the README should be updated?
I see multiple CI failures for your PR.
| @@ -0,0 +1,35 @@ | |||
| # ============================================================================= | |||
There was a problem hiding this comment.
I think you also need https://www.gnu.org/software/autoconf-archive/ax_cxx_compile_stdcxx.html in this m4 directory?
m4/ax_cxx_compile_stdcxx.m4
Outdated
|
|
||
| #endif // __cplusplus < 202002L && !defined _MSC_VER | ||
|
|
||
| ]]) No newline at end of file |
There was a problem hiding this comment.
file is missing a trailing newline character (applies to all the other new files as well)
I'm not sure about the exact cause of the CI failures at the moment. Could you please provide more details about the specific failures? I'd be happy to investigate further and work on resolving these issues. Any additional information or logs you can share as it will help me address the problems more effectively |
I am pretty sure that the detailed log output of all CI tests, whether they are failing or successful, are publicly available to anyone. If you look at this PR on github.com at this link #1266 and scroll down to the bottom, near the bottom you should see a list of tests with names like these, and a "Details" link to the right of each one:
as well as some tests that have been successful. |
|
@antoninbas Are there any additional changes or updates that need? |
|
@OsamaRab3 At least one commit is not signed, so the DCO check is failing. I'd suggest squashing all 4 commits, and signing the resulting commit. |
|
@antoninbas I reviewed the DCO check failure details and noticed that it was due to missing "Signed-off-by" lines in the commit messages. Following the instructions provided in the error message, I have rebased the branch and added the necessary "Signed-off-by" lines to each commit. |
m4/ax_cxx_compile_stdcxx_17.m4
Outdated
| #serial 2 | ||
|
|
||
| AX_REQUIRE_DEFINED([AX_CXX_COMPILE_STDCXX]) | ||
| AC_DEFUN([AX_CXX_COMPILE_STDCXX_17], [AX_CXX_COMPILE_STDCXX([17], [$1], [$2])]) No newline at end of file |
| #serial 2 | ||
|
|
||
| AX_REQUIRE_DEFINED([AX_CXX_COMPILE_STDCXX]) | ||
| AC_DEFUN([AX_CXX_COMPILE_STDCXX_17], [AX_CXX_COMPILE_STDCXX([17], [$1], [$2])]) No newline at end of file |
Signed-off-by: osama <osrab3@gmail.com>
Signed-off-by: osama <osrab3@gmail.com>
Signed-off-by: osama <osrab3@gmail.com>
Signed-off-by: osama <osrab3@gmail.com>
Signed-off-by: osama <osrab3@gmail.com>
|
@antoninbas any thing else? |
3 participants
enforce -std=c++17 support using AX_CXX_COMPILE_STDCXX_17