This repository was archived by the owner on Dec 14, 2023. It is now read-only.
Fix issue 143: Quoting of TXT records#165
Merged
Merged
Conversation
Signed-off-by: pacoorozco <paco@pacoorozco.info>
Signed-off-by: pacoorozco <paco@pacoorozco.info>
Signed-off-by: pacoorozco <paco@pacoorozco.info>
Signed-off-by: pacoorozco <paco@pacoorozco.info>
Signed-off-by: pacoorozco <paco@pacoorozco.info>
This reverts commit 145a938.
Signed-off-by: pacoorozco <paco@pacoorozco.info>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind bug
What is this pull request for? Which issues does it resolve? (use
resolves #<issue_number>if possible)resolves #143
closes #144
Does this pull request has user-facing changes? (e.g. config changes, new/modified commands, new/modified flags)
Yes, it will change (fix) the way that a TXT record is print in the zone file. It's following what is described in #143.
Does this pull request add new dependencies?
No