Regroup sentinels#3048
Merged
Rowlando13 merged 1 commit intopallets:mainfrom Aug 26, 2025
kdeldycke:regroup-sentinels
Merged
Conversation
davidism
approved these changes
Aug 24, 2025
Collaborator
Author
|
@Rowlando13 I guess this is a green-light from @davidism to merge this one! 😉 |
Collaborator
Author
|
Thanks @Rowlando13 for the merge! 😃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small refactor to regroup all sentinels used across the Click codebase to the same private
_utils.pyfile.With this change:
The new
FLAG_NEEDS_VALUEsentinel is self-documenting. Compare:with:
An option's
_flag_needs_valueproperty cannot be confused with theFLAG_NEEDS_VALUEsentinel as they are now clearly distinct by their naming convention.