Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the
Hostheader is missing, such as for HTTP/0.9 and 1.0, or has invalid characters,get_hostandRequest.hostreturn the empty string. Iftrusted_hostsis passed, a missing value is allowed, but an invalid value results in an error.This relaxes the validation a bit, so that empty and invalid values don't cause requests to immediately fail. Subdomain and host routing, and external URL building, will not work though, as they need a host value.
If something is generating invalid hostnames, you need to report a bug to that thing.
fixes #3142