[SITE-5456] Add support for Solr 9 in D7#223
Open
rkunjappan wants to merge 2 commits intodefaultfrom
Open
Conversation
rkunjappan
changed the title
pwtyler
reviewed
Apr 24, 2026
| run: .github/update_tag1_d7es.sh | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} No newline at end of file | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
Member
There was a problem hiding this comment.
back this out, ci files are missing on master branch so this will fail the cherry pick.
Comment on lines
+182
to
+188
| /** | ||
| * Return 'true' if the Pantheon Search Version is detected. | ||
| * @return bool | ||
| */ | ||
| function pantheon_apachesolr_search_version_detected() { | ||
| return isset($_ENV['search_version']); | ||
| } |
Member
There was a problem hiding this comment.
this method is only used once. just roll into pantheon_apachesolr_get_search_version.
| CURLOPT_POSTFIELDS => json_encode($files), | ||
| ); | ||
|
|
||
| curl_setopt_array($ch, $opts); |
Member
There was a problem hiding this comment.
All other cases this is managed with pantheon_apachesolr_curl_setup and then adjusted, should we do here again, or is there a reason we're not?
Comment on lines
+222
to
+225
| /** | ||
| * Legacy Supported Class for RC2. | ||
| */ | ||
| class PantheonSearchApiSolrService extends SearchApiSolrConnection { |
Member
There was a problem hiding this comment.
Looks like a merge conflict artifact, this was removed.
Comment on lines
128
to
129
| class PantheonApachesolrSearchApiSolrService extends SearchApiSolrService { | ||
| protected $connection_class = 'PantheonApachesolrSearchApiSolrConnection'; |
Member
There was a problem hiding this comment.
Confirming all of the new methods in here are from Promet/you as well (see previous comment re cleanup)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Solr 9 support for Drupal 7 on Pantheon. Built on top of Promet's Solr 8 work (PR #221), adapted for Solr 9, and integrated with Tag1's curl setup improvements on
default.What Promet did (Solr8 support)
$_ENV['search_version']PANTHEON_INDEX_HOST,PANTHEON_INDEX_PORT, etc.)pantheon_apachesolr_client_cert()andpantheon_apachesolr_certs_dir()for mTLS cert handlingPantheon_Search_Api_Solr_Service.phpwith Solr 8 connection/service/ping overridesPantheon_Apache_Solr_Service.php(becauseapachesolrmodule didn't support Solr 8)Tag1 (on
defaultbranch)pantheon_apachesolr_curl_setup()helper for curl configuration withbinding.pem(commitd09a9273b)binding.pemdoesn't exist (disables SSL verification)This PR(solr9 support)
SITE-5456-solr9branch.module, Search API Solr service)== 8to== 9and version strings fromv8.11.0tov9.10.08.xto9.xpantheon_apachesolr_curl_setup()with Promet's SSL/cert code inPantheon_Search_Api_Solr_Service.phpPantheon_Apache_Solr_Service.php(Promet didn't touch this file sinceapachesolrdidn't support Solr 8, butapachesolr7.x-1.14 has native Solr 9 support)setStats(): JSON parsing from/admin/systemfor Solr 9 (vs XML from/admin/stats.jspfor Solr 3)getStatsSummary(): extract schema/core info from JSON response for Solr 9Files changed
pantheon_apachesolr.modulePantheon_Search_Api_Solr_Service.phpPantheon_Apache_Solr_Service.php.github/workflows/update_tag1_d7es.ymlModule compatibility
apachesolr) 7.x-1.14search_api_solr) 7.x-1.19Tag1 released Search API Solr version 7.x-1.8 with solr 9 support, so no need for community patch
Jira
SITE-5456