Improve HMR#10017
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parcelRequireto load a module by id, so a dependency was never added to the graph. The HMR runtime relies on dependencies being declared so it can traverse parents. In this PR we track the ids that areparcelRequireed and add them in the dev packager so that we can travers from the child through runtimes.module.hot.acceptdecides that it cannot handle an update for whatever reason, it can callgetParentsand return additional assets to bubble to. However, we previously only bubbled to those direct parents and no further. This PR fixes that so that we continue bubbling, and reload if not accepted.priority(e.g. the glob resolver), but this was overwritten in core the next time it was resolved instead of merging. Solved similar to how we did formeta.