Skip to content

Fix duplicate bundles error message empty bundle list#10119

Merged
devongovett merged 2 commits into
parcel-bundler:v2from
maxburs:validate-bundles-fix
Mar 29, 2025
Merged

Fix duplicate bundles error message empty bundle list#10119
devongovett merged 2 commits into
parcel-bundler:v2from
maxburs:validate-bundles-fix

Conversation

@maxburs

@maxburs maxburs commented Mar 20, 2025

Copy link
Copy Markdown
Contributor

Fixes #10125

↪️ Pull Request

setDifference(new Set(bundleNames), new Set(unique(bundleNames))) always returns an empty Set, resulting in an empty bundle list in the error message.

💻 Examples

🚨 Test instructions

✔️ PR Todo

  • Added/updated unit tests for this change
  • Filled out test instructions (In case there aren't any unit tests)
  • Included links to related issues/PRs

@devongovett devongovett force-pushed the validate-bundles-fix branch from 2cbec8d to 91b6b1b Compare March 29, 2025 19:59
@devongovett devongovett merged commit af39c8a into parcel-bundler:v2 Mar 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bundle validation fails with bad message

2 participants