Fix Vue asset supplemental code concatenation#1362
Merged
devongovett merged 2 commits intoMay 22, 2018
Conversation
Contributor
Author
|
@DeMoorJasper This fixes my @TooBug Would you be interested in testing this? |
Member
Contributor
Author
|
This PR may also fix #1294. @carbontwelve @luikore It would be very helpful if you could test this. |
|
Im going to test this today and will report back. |
|
Tested with relation to #1294 and it still returns a broken build. |
DeMoorJasper
approved these changes
May 14, 2018
Contributor
Author
|
@carbontwelve Okay, thanks. |
The user code may have comments at the end, which could cause the first line of the supplemental code to be commented out.
devongovett
approved these changes
May 22, 2018
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is intended to fix #1350 and probably also #1344.
Without this fix, the user's code is minified just fine; however, supplemental code is minified separately, then appended to the user's code in the same scope. This can cause a symbol naming clash which breaks the user's code.