Fix security vulnerability#1794
Merged
Merged
Conversation
fathyb
approved these changes
Jul 25, 2018
fathyb
left a comment
fathyb
left a comment
Contributor
There was a problem hiding this comment.
LGTM, did someone check if this effectively fixes the issue, e.g. using a POC?
Member
Author
|
@chromium1337 Wrote a page about it explaining why it's an issue and origin would fix this. I'll DM you the page |
devongovett
approved these changes
Sep 25, 2018
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
carlosgeos
pushed a commit
to carlosgeos/parcel
that referenced
this pull request
Jan 1, 2019
carlosgeos
pushed a commit
to carlosgeos/parcel
that referenced
this pull request
Jan 2, 2019
tests use the ws library to establish a websocket connection, and they have an undefined origin by default. This is changed tests have no defined hmrHostname so it was set too.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After having a short discussion with @chromium1337 we found a fix for the security vulnerability #1783
The vulnerability mainly had to do with people being able to steal your code as the origin of requests wasn't checked by websocket server.
However the CORS header in the static server comes down to the same vulnerability and as there is no general hostname flag, we can't really secure that server.
Unless we would agree, that both these hostnames would always be the same and deprecate
--hmr-hostnameand create a--hostnameflag instead that adds a cors limitation to both the static and websocket server. This way allowing parcel to be run on a server without having to worry about any security risks (related to CORS).Fixes #1783