Skip to content

Minimal verbose mode#1834

Merged
devongovett merged 5 commits into
masterfrom
minimal-verbose-mode
Aug 24, 2018
Merged

Minimal verbose mode#1834
devongovett merged 5 commits into
masterfrom
minimal-verbose-mode

Conversation

@DeMoorJasper

@DeMoorJasper DeMoorJasper commented Aug 2, 2018

Copy link
Copy Markdown
Member

Adds verbose and debug mode:

4: verbose, keep everything in log with timestamps, instead of using statusspinner
5: debug, save everything to a file with timestamps

Shouldn't slow down anything, verbose might even speed everything up as it uses native console.log instead of a spinner.

Also adds a log call after an asset has been processed to track which files are being successfully built

Closes #993

Comment thread src/cli.js Outdated
@@ -59,7 +59,7 @@ program
.option(
'--log-level <level>',
'set the log level, either "0" (no output), "1" (errors), "2" (warnings + errors) or "3" (all).',

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update this message to add the new verbose modes?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably, updated it to include the verbose and debug mode

Comment thread src/Logger.js Outdated
`parcel-debug-${currDate.toLocaleDateString()}@${currDate.toLocaleTimeString()}.log`
)
);
this.logFile.write = this.logFile.write.bind(this.logFile);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this bind needed?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think so, I'll remove it, seems to work fine without

@devongovett devongovett merged commit 4868462 into master Aug 24, 2018
@devongovett devongovett deleted the minimal-verbose-mode branch August 24, 2018 19:15
@DeMoorJasper DeMoorJasper mentioned this pull request Aug 28, 2018
devongovett pushed a commit that referenced this pull request Oct 15, 2018
devongovett pushed a commit that referenced this pull request Oct 15, 2018
codeaholicguy added a commit to codeaholicguy/website that referenced this pull request Oct 25, 2018
Follow parcel-bundler/parcel#1834

I add `verbose` and `debug` options to log level
DeMoorJasper pushed a commit to parcel-bundler/website that referenced this pull request Oct 25, 2018
Follow parcel-bundler/parcel#1834

I add `verbose` and `debug` options to log level
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants