Fix hoist of modules with multiple aliases#2077
Merged
Merged
Conversation
Can be reproduced using the `to-function` package
devongovett
previously approved these changes
Oct 6, 2018
devongovett
approved these changes
Oct 6, 2018
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
name: Fix hoist of modules with multiple aliases
↪️ Pull Request
When a module has multiple aliases it can get trimmed from the output, triggering reference errors at runtime.
💻 Examples
parcel build a.js --experimental-scope-hoist && node dist/a.jsa.js✔️ PR Todo