Fix HMR for Pug assets#2091
Merged
Merged
Conversation
- Added tests for pug - Added config files support (.pugrc, .pugrc.js, pug.config.js) - Added custom filters support (must be declared in config file in section 'filters')
DeMoorJasper
approved these changes
Oct 2, 2018
This was referenced Oct 2, 2018
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
--- name: 🙋 Fix HMR for Pug assets --- <!--- Thanks for filing a pull request 😄 ! Before you submit, please read the following: Search open/closed issues before submitting since someone might have pushed the same thing before! --> ## ↪️ Pull Request <!--- Provide a general summary of the pull request here Does this address an existing issue? --> #2090 ## 💻 Examples <!-- Examples help us understand the requested feature better --> ## ✔️ PR Todo - [ ] Added/updated unit tests for this change - [ ] Filled out test instructions - [x] Included links to related issues/PRs <!-- Love parcel? Please consider supporting our collective: 👉 https://opencollective.com/parcel/donate -->
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
--- name: 🙋 Fix HMR for Pug assets --- <!--- Thanks for filing a pull request 😄 ! Before you submit, please read the following: Search open/closed issues before submitting since someone might have pushed the same thing before! --> ## ↪️ Pull Request <!--- Provide a general summary of the pull request here Does this address an existing issue? --> #2090 ## 💻 Examples <!-- Examples help us understand the requested feature better --> ## ✔️ PR Todo - [ ] Added/updated unit tests for this change - [ ] Filled out test instructions - [x] Included links to related issues/PRs <!-- Love parcel? Please consider supporting our collective: 👉 https://opencollective.com/parcel/donate -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
name: 🙋 Fix HMR for Pug assets
↪️ Pull Request
#2090
💻 Examples
✔️ PR Todo