Possibility to use .postcssrc.json as PostCSS config file#2115
Merged
Conversation
devongovett
approved these changes
Oct 6, 2018
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
I find defining PostCSS config in
.postcssrc.jsonmore consistent with another config files like.eslintrc.jsonand.babelrc.json. I prefer this way of naming because of transparency and conformity between the filename and content type.Also, postcss-load-config package, which is widely using with PostCSS, supports this way of defining configs and enforces this naming as recommended.
I think adding
.postcssrc.jsonto resolvable configs makes parcel more smooth to switch from another bundler without much effort 🙂I didn't find any tests for PostCSS config files, so I'm not sure if I should add ones for this feature 😕