Add support for HMR with elm-hot#2388
Merged
Merged
Conversation
3 tasks
devongovett
approved these changes
Dec 11, 2018
Member
|
Awesome, thank you! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a copy of #2378, which is having some technical difficulties.
↪️ Pull Request
This PR adds integration with elm-hot - the HMR solution for Elm (at least I don't know about any other :-)). I've published this code before as a plugin, and after a suggestion from @domenkozar decided it would make more sense upstream.
💻 Examples
This will help when editing the app without changing the type of the app's model. Visual tweaks or testing the update logic should be much easier with working HMR.
🚨 Test instructions
Editing an Elm app (like changing a string) should cause the changes to be applied, without refreshing the page or changing the app's state.
✔️ PR Todo