Implement depth option for detaild report#2466
Merged
devongovett merged 3 commits intoMar 6, 2019
Merged
Conversation
720d7c3 to
cfe442d
Compare
devongovett
approved these changes
Mar 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
Allows define a depth for the
detailedReportoption. Implements #1857.💻 Examples
Show all assets used within bundles:
Show the largest 50 assets per bundle:
🚨 Test instructions
With this changes, when the
--detailed-reportargument is used via cli without an option, it must be used after the path to the resource, because otherwise it would use the file name as its value.Right:
parcel build ./path/to/file.ts --detailed-reportWrong:
parcel build --detailed-report ./path/to/file.tsNot sure if this is considered a breaking change for parcel, I did not found a good way to solve this using
commanderwhich is used for parsing the command on the shell.✔️ PR Todo