Skip to content

fix-dependency-tag-with-empty-value #2553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DeMoorJasper merged 2 commits into from
Feb 9, 2019
Merged

fix-dependency-tag-with-empty-value #2553

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ae169a
fix-dependency-tag-with-empty-value
abdullahtariq1171 Jan 18, 2019
93bd86f
Merge branch 'master' into fix-dependency-tag-with-empty-value
DeMoorJasper Feb 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions packages/core/parcel-bundler/src/assets/HTMLAsset.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,18 +168,25 @@ class HTMLAsset extends Asset {
}

for (let attr in node.attrs) {
let elements = ATTRS[attr];
const attrVal = node.attrs[attr];

if (!attrVal) {
continue;
}

// Check for virtual paths
if (node.tag === 'a' && node.attrs[attr].lastIndexOf('.') < 1) {
if (node.tag === 'a' && attrVal.lastIndexOf('.') < 1) {
continue;
}

let elements = ATTRS[attr];

if (elements && elements.includes(node.tag)) {
let depHandler = this.getAttrDepHandler(attr);
let options = OPTIONS[node.tag];
node.attrs[attr] = depHandler.call(
this,
node.attrs[attr],
attrVal,
options && options[attr]
);
this.isAstDirty = true;
Expand Down
⚡