Improve tests: symlink tests, Kotlin tests, and maybe test-util module#2605
Merged
Conversation
Member
|
This might be a big ask but could you have a look at the failing watcher test in CI as you're on windows you might be in a better position to fix it than we are? I'll have a look at the other changes tomorrow and add a review |
Contributor
Author
|
Ok. I'll try. I've opened the issue #2609 for that problem. |
…s into test-utils/src/utils.js. (parcel-bundler#2604)
DeMoorJasper
approved these changes
Feb 1, 2019
DeMoorJasper
requested changes
Feb 1, 2019
DeMoorJasper
left a comment
DeMoorJasper
left a comment
Member
There was a problem hiding this comment.
Could you try to resolve the linting issues?
DeMoorJasper
previously approved these changes
Feb 2, 2019
DeMoorJasper
approved these changes
Feb 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
I messed up my old PR(#2590) with merge, so I closed it and created a new one.
This PR will fix some test problems on Windows 10.
This PR will close #2602, #2603, maybe #2604 if you say yes.
💻 Examples, 🚨 Test instructions
Written in issues and old PRs.
✔️ PR Todo