Skip to content

Scope Hoisting: Throw meaningful error on undefined exports#2693

Merged
devongovett merged 1 commit into
masterfrom
scope-hoisting-undefined-export
Mar 6, 2019
Merged

Scope Hoisting: Throw meaningful error on undefined exports#2693
devongovett merged 1 commit into
masterfrom
scope-hoisting-undefined-export

Conversation

@mischnic

Copy link
Copy Markdown
Member

↪️ Pull Request

Previously:
lib2.js: Cannot read property 'constantViolations' of undefined
Now:
lib2.js: export 'Multiply' is not defined

💻 Examples

export {Multiply};

✔️ PR Todo

  • Added/updated unit tests for this change
  • Filled out test instructions (In case there aren't any unit tests)
  • Included links to related issues/PRs

@mischnic mischnic changed the title Throw meaningful error on undefined exports Scope Hoisting: Throw meaningful error on undefined exports Feb 27, 2019
@devongovett devongovett merged commit 2a55296 into master Mar 6, 2019
@devongovett devongovett deleted the scope-hoisting-undefined-export branch March 6, 2019 04:27
@lukyth lukyth mentioned this pull request Mar 25, 2019
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants