Fix bug with original null mappings#2748
Merged
Merged
Conversation
devongovett
approved these changes
Mar 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
If an original mapping had null and that map needed to be extended (aka null mappings from node_modules & TS).
originalPositionFortried to get the location of this mapping.Fixes #2738
💻 Examples
https://github.com/ross-pfahler/parcel-sourcemap-bug (note: remove yarn.lock if using yarn as it uses the Adobe corp artifactory)
🚨 Test instructions
Run the Repo it should work. Probably gonna add a test for this though.
Tried to write a test for this but it seems hard to write a minimal repro testcase for this. This was probably also the reason I never added tests for sourcemaps in node_modules.
✔️ PR Todo