-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Dynamic imports priority fix closes #6980 #7061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
devongovett
merged 16 commits into
parcel-bundler:v2
from
highvoltag3:dynamic-imports-priority-fix
Mar 20, 2022
+53
−23
Merged
Changes from 9 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
59a61fa
Dynamic imports loaded as low-priority scripts when compiled, fixes #…
highvoltag3 6635443
Fixing unit test for dynamic imports loaded as high-priority scripts …
highvoltag3 b2d0671
Making sure an specific browser is set, cleanup to remove noise from …
highvoltag3 8b81a48
Merge branch 'parcel-bundler:v2' into dynamic-imports-priority-fix
highvoltag3 d3d3eb8
Merge branch 'dynamic-imports-priority-fix' of https://github.com/hig…
highvoltag3 c3fd13e
Merge branch 'parcel-bundler:v2' into dynamic-imports-priority-fix
highvoltag3 cb3fb47
Tweak test to assert that the inserted link url matches the loaded sc…
highvoltag3 5528b80
Merge branch 'v2' into dynamic-imports-priority-fix
2b749eb
link => preloadLink
f8b5d8b
Insert preload once; fix tests
41913d8
Merge branch 'v2' into dynamic-imports-priority-fix
b9c77a4
Merge branch 'v2' into dynamic-imports-priority-fix
eafe713
Merge branch 'v2' into dynamic-imports-priority-fix
41706b7
Merge branch 'v2' into dynamic-imports-priority-fix
c2869c2
Merge branch 'v2' into dynamic-imports-priority-fix
12a1d6c
Merge branch 'v2' into dynamic-imports-priority-fix
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
1 change: 1 addition & 0 deletions
1
packages/core/integration-tests/test/integration/dynamic-imports-high-prio/async.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| export default {}; |
1 change: 1 addition & 0 deletions
1
packages/core/integration-tests/test/integration/dynamic-imports-high-prio/index.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| export default import('./async').then(() => document.head.children); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.