Fix type generation when tsconfig's "incremental" option is true#7352
Merged
devongovett merged 2 commits intoNov 28, 2021
Merged
Conversation
|
devongovett
approved these changes
Nov 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
This fixes #7351
The issue is that
@parcel/transformer-typescript-typeswill output blank.d.tsfiles when the user supplies atsconfig.jsonwith"incremental": true. The solution is to override this to ensure that we always set it to false before trying to generate types.It's a follow up to #5346 and tweaks the unit test from that PR to cover both the original case, and this one.
💻 Examples
Examples are in the original bug (#7351).
✔️ PR Todo