Update: allow empty string toml config#7418
Merged
mischnic merged 4 commits intoDec 11, 2021
Merged
Conversation
|
devongovett
approved these changes
Dec 9, 2021
3 tasks
bhovhannes
pushed a commit
to bhovhannes/parcel
that referenced
this pull request
Dec 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
Fixes: #7371
Hi! team 👋
Currently,
loadConfigmodule early returns null when configuration file is an empty string. However, some files such as.tomland.yamlallow an empty string file, soloadConfigshould not early return null when the config file is an empty string.I fixed this behavior to parse also empty string files (, and a file parser throws an error when a file parser such as JSON does not allow empty string).
💻 Examples
with empty json
🚨 Test instructions
loadConfigshould throw an error with the invalid empty string JSONloadConfigcan load a valid empty string toml✔️ PR Todo